Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-UTILS-GPROFILER REWORK (4): Redirect unchanged utils to g-utils #926

Open
wants to merge 3 commits into
base: update-submodule
Choose a base branch
from

Conversation

granulatedekel
Copy link

@granulatedekel granulatedekel commented Sep 23, 2024

Part of the G-UTILS-GPROFILER REWORK saga - which aims to move away shared code from gprofiler to the g-utils project:
intel/granulate-utils#263 intel/granulate-utils#261 #925 #926 #926

This PR is responsible for handling simple utils that required no logical change to just redirect to g-utils (spare us the cross-project code changes - debatable if worth pursuing)

@granulatedekel granulatedekel changed the base branch from update-submodule to update-packages September 23, 2024 22:03
@granulatedekel granulatedekel changed the base branch from update-packages to update-submodule September 23, 2024 22:03
@granulatedekel granulatedekel changed the title Refactor into g utils condensed G-UTILS REWORK (2): Redirect unchanged utils to g-utils Sep 23, 2024
@granulatedekel granulatedekel changed the title G-UTILS REWORK (2): Redirect unchanged utils to g-utils G-UTILS-GPROFILER REWORK (4): Redirect unchanged utils to g-utils Sep 23, 2024
@granulatedekel granulatedekel added the g-utils-gprofiler-rework PRs related to the G-UTILS-GPROFILER saga label Sep 23, 2024
@granulatedekel granulatedekel marked this pull request as ready for review September 23, 2024 22:52
@YoniKF YoniKF requested a review from roi-granulate October 1, 2024 10:15
Copy link
Contributor

@roi-granulate roi-granulate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason wildcard import are preferred here?
if not - let's use explicit imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
g-utils-gprofiler-rework PRs related to the G-UTILS-GPROFILER saga
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants