-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Python 3.11 #873
Open
Jongy
wants to merge
20
commits into
grpcio-1-62-2
Choose a base branch
from
python-3.11
base: grpcio-1-62-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
build: Python 3.11 #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongy
commented
Jan 4, 2024
@@ -164,8 +164,9 @@ RUN yum install -y \ | |||
yum clean all | |||
COPY ./scripts/openssl_build.sh . | |||
RUN ./openssl_build.sh | |||
COPY ./scripts/python310_build.sh . | |||
RUN ./python310_build.sh | |||
COPY ./scripts/python311_build.sh . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing ws
Jongy
commented
Jan 4, 2024
scripts/python311_build.sh
Outdated
# | ||
set -euo pipefail | ||
|
||
wget https://www.python.org/ftp/python/3.11.3/Python-3.11.3.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade to latest patchlevel
It would be great if someone who has arm machine could test |
81816b7
to
de24119
Compare
664141c
to
2fb9611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the Python version used for the gProfiler executable from 3.10 to 3.11.
As part of the upgrade, I try to upgrade grpcio, as we concluded it's needed here.
This continues PR #771.