-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate image & executable build into exe-in-image #582
Labels
build
Image/executable build
defined-and-prioritized
Tickets that have fully defined the desired outcome & are prioritized to be developed.
Comments
I think we'll go for this after #597 is merged and we're using a newer Python in the exe, I don't want to force all releases to use the Python 3.6 we have in the exe which has some bugs that we encounter in flaky tests. |
Jongy
added a commit
that referenced
this issue
Dec 15, 2022
Follows intel/granulate-utils#107 to do the same for gProfiler. Now the container build uses 3.8, so that's the minimal supported version. If we ugprade the container to Ubuntu 22.04 or implement #582, the minimal supported version will be 3.10 :)
Additional elaboration:
|
More notes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Image/executable build
defined-and-prioritized
Tickets that have fully defined the desired outcome & are prioritized to be developed.
We have 2 Dockerfiles (
Dockerfile
andDockerfile.pyi
) which result in an image and in an exe. Instead of maintaining 2 builds, we can remove the image build, and instead the image Dockerfile would become:Upsides:
Downsides:
python -m gprofiler
(haven't tried that in a long while).The text was updated successfully, but these errors were encountered: