Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

[v1.2][ISSUE-374] deltatuner denas-ssf multiple model validation and model merge #375

Merged
merged 49 commits into from
Oct 11, 2023

Conversation

zhouyu5
Copy link
Contributor

@zhouyu5 zhouyu5 commented Oct 10, 2023

What changes were proposed in this pull request?

  • refine the code to support multi LLM models for ssf, and update the readme
  • refactor the code to support easy-to-use model merge utility for ssf

Why are the changes needed?

  • To prove the deltatuner's compatible with multiple models
  • To improve the user experience

How was this patch tested?

deltatuner ci/cd has covered this PR's change

@github-actions
Copy link

Thanks for opening a pull request!

Please open an issue for this pull request on Github Issues as well.

https://github.com/intel/e2eAIOK/issues

Pull Request Name format: [${VERSION_ID}][ISSUE-${ISSUES_ID}] ${detailed message}
ex: [v1.1][ISSUE-190] Add PR to issue link

@zhouyu5
Copy link
Contributor Author

zhouyu5 commented Oct 11, 2023

@XinyaoWa @tianyil1 Please review this PR. Feel free to leave your comments.

Copy link
Contributor

@tianyil1 tianyil1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left come comments below.

Copy link
Contributor

@tianyil1 tianyil1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouyu5
Copy link
Contributor Author

zhouyu5 commented Oct 11, 2023

@xuechendi Please have a check. It is now ready to merge.

Copy link
Contributor

@xuechendi xuechendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuechendi
Copy link
Contributor

@zhouyu5 , I will merge this PR. BTW, reading through comments, I think there are some design changes happened, can you also wrap up a design doc or point me existing design doc, so I can understand the workflow and class diagram from there?

@xuechendi xuechendi merged commit a91a25b into intel:main Oct 11, 2023
2 checks passed
@zhouyu5
Copy link
Contributor Author

zhouyu5 commented Oct 12, 2023

@zhouyu5 , I will merge this PR. BTW, reading through comments, I think there are some design changes happened, can you also wrap up a design doc or point me existing design doc, so I can understand the workflow and class diagram from there?

Actually, the API keep unchanged, just some small internal changes. We don't have a design doc yet, but we will begin to prepare a design doc. Please stay tuned.

@zhouyu5 zhouyu5 deleted the dtuner_test branch December 8, 2023 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants