-
Notifications
You must be signed in to change notification settings - Fork 20
[v1.2][ISSUE-374] deltatuner denas-ssf multiple model validation and model merge #375
Conversation
* bug fix
Thanks for opening a pull request! Please open an issue for this pull request on Github Issues as well. https://github.com/intel/e2eAIOK/issues Pull Request Name format: [${VERSION_ID}][ISSUE-${ISSUES_ID}] ${detailed message} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left come comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xuechendi Please have a check. It is now ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zhouyu5 , I will merge this PR. BTW, reading through comments, I think there are some design changes happened, can you also wrap up a design doc or point me existing design doc, so I can understand the workflow and class diagram from there? |
Actually, the API keep unchanged, just some small internal changes. We don't have a design doc yet, but we will begin to prepare a design doc. Please stay tuned. |
What changes were proposed in this pull request?
Why are the changes needed?
How was this patch tested?
deltatuner ci/cd has covered this PR's change