-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds support for version python version 3.13 #4668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need a second set of long tests here and I'm not sure these will even work properly since they've got the same long_tests
identifier, so that will definitely need to change before merging. That said, I'm guessing we should try running the long tests in CI on python 3.13 once so I'm going to approve the workflow now just to see what happens before you clean it up.
Darn, looks like the duplicate entry just makes the whole testing file invalid so none of it is running. You'll have to fix it before even the short tests will run! |
I had changed |
Looks like things queued properly this time! I'll be back to check on results later. |
Should I remove long tests for 3.13? Additionally any thing else needs attention? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's remove the extra long tests and then merge this. It looks like things are working well enough. Thanks for investigating this and getting it ready!
Yes done, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks like we're good to go now. The hanging test is NVD related and I'll open a separate issue for it.
And congratulations on your first merged commit with us! 🎆 |
Thank you! I'm excited to stick around! |
Fixes: #4663