Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds support for version python version 3.13 #4668

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

Prtm2110
Copy link
Contributor

@Prtm2110 Prtm2110 commented Jan 3, 2025

Fixes: #4663

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a second set of long tests here and I'm not sure these will even work properly since they've got the same long_tests identifier, so that will definitely need to change before merging. That said, I'm guessing we should try running the long tests in CI on python 3.13 once so I'm going to approve the workflow now just to see what happens before you clean it up.

@terriko
Copy link
Contributor

terriko commented Jan 3, 2025

Darn, looks like the duplicate entry just makes the whole testing file invalid so none of it is running. You'll have to fix it before even the short tests will run!

@Prtm2110
Copy link
Contributor Author

Prtm2110 commented Jan 3, 2025

We don't need a second set of long tests here and I'm not sure these will even work properly since they've got the same long_tests identifier, so that will definitely need to change before merging.

I had changed long_tests in my commits uh but didn't push I guess.
Could you run it now? then I will remove long tests for 3.13.

@terriko
Copy link
Contributor

terriko commented Jan 3, 2025

Looks like things queued properly this time! I'll be back to check on results later.

@Prtm2110
Copy link
Contributor Author

Prtm2110 commented Jan 8, 2025

Should I remove long tests for 3.13? Additionally any thing else needs attention?

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's remove the extra long tests and then merge this. It looks like things are working well enough. Thanks for investigating this and getting it ready!

@Prtm2110
Copy link
Contributor Author

Prtm2110 commented Jan 8, 2025

Yes, let's remove the extra long tests and then merge this. It looks like things are working well enough. Thanks for investigating this and getting it ready!

Yes done, thank you!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like we're good to go now. The hanging test is NVD related and I'll open a separate issue for it.

@terriko
Copy link
Contributor

terriko commented Jan 8, 2025

And congratulations on your first merged commit with us! 🎆

@terriko terriko merged commit 7e0a7fd into intel:main Jan 8, 2025
23 of 24 checks passed
@Prtm2110
Copy link
Contributor Author

Prtm2110 commented Jan 8, 2025

And congratulations on your first merged commit with us! 🎆

Thank you! I'm excited to stick around!

@Prtm2110 Prtm2110 deleted the 3.13_support branch January 8, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: check and see if we can run on python 3.13
2 participants