fix: halt if pdf selected but unavailable #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Related to intel#4326 If pdf output is selected but isn't available, then cve-bin-tool tells you to install reportlab, but it was easy to miss that message as the scan continued and pushed it off the screen. This changes those messages to be errors insead of info messages, and exits without doing a scan if pdf is the only output mode selected. Signed-off-by: Terri Oda <terri.oda@intel.com>
Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko
requested review from
inosmeet,
anthonyharrison and
nedsouza
and removed request for
anthonyharrison and
nedsouza
nedsouza
requested changes
Aug 20, 2024
|
looks good : ) |
nedsouza
approved these changes
Aug 20, 2024
terriko
added a commit
to terriko/cve-bin-tool
that referenced
this pull request
Aug 20, 2024
Adds a regression test for 0-cve pdf report behaviour. This should help us avoid bugs that cause the report to fail in the case where 0 cves were found. This is the last piece needed to close intel#4326. Other pieces: * intel#4329 fixed the check that was causing report generaiton to fail. * intel#4354 changed the UI so it's more obvious when reportlab is needed. * fixes intel#4326 Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko
added a commit
that referenced
this pull request
Aug 21, 2024
Adds a regression test for 0-cve pdf report behaviour. This should help us avoid bugs that cause the report to fail in the case where 0 cves were found. This is the last piece needed to close #4326. Other pieces: * #4329 fixed the check that was causing report generaiton to fail. * #4354 changed the UI so it's more obvious when reportlab is needed. * fixes #4326 Signed-off-by: Terri Oda <terri.oda@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pdf output is selected but isn't available, then cve-bin-tool tells you to install reportlab, but it was easy to miss that message as the scan continued and pushed it off the screen. This changes those messages to be errors insead of info messages, and exits without doing a scan if pdf is the only output mode selected.