Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: no entrypoint registration required in tree #4207

Merged
merged 1 commit into from
Jun 24, 2024
Merged

feat: no entrypoint registration required in tree #4207

merged 1 commit into from
Jun 24, 2024

Conversation

johnandersen777
Copy link

@johnandersen777 johnandersen777 commented Jun 21, 2024 •
edited
Loading

@johnandersen777 johnandersen777 force-pushed the no-entrypoints-for-in-tree branch 4 times, most recently from 214d2b8 to df36bba Compare June 21, 2024 00:52
@johnandersen777 johnandersen777 marked this pull request as ready for review June 21, 2024 00:52
@johnandersen777 johnandersen777 force-pushed the no-entrypoints-for-in-tree branch from df36bba to 78663d1 Compare June 21, 2024 00:59
@johnandersen777 johnandersen777 marked this pull request as draft June 21, 2024 02:11
@johnandersen777 johnandersen777 force-pushed the no-entrypoints-for-in-tree branch 5 times, most recently from 2f6fe31 to ce58f32 Compare June 21, 2024 19:10
@johnandersen777 johnandersen777 marked this pull request as ready for review June 21, 2024 19:48
@johnandersen777 johnandersen777 requested a review from terriko June 21, 2024 19:48
@pdxjohnny
feat: no entrypoint registration required in tree
a4c456e 
Signed-off-by: John Andersen <john.s.andersen@intel.com>
@johnandersen777 johnandersen777 force-pushed the no-entrypoints-for-in-tree branch from ce58f32 to a4c456e Compare June 22, 2024 01:36
terriko
terriko approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is going to have different weird "checker not loading" side effects than the old code, but it looks good. Thank you again @pdxjohnny !

@terriko terriko merged commit 8c6d3dd into intel:main Jun 24, 2024
22 checks passed
@johnandersen777 johnandersen777 deleted the no-entrypoints-for-in-tree branch June 27, 2024 15:31
@anthonyharrison anthonyharrison mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnandersen777 @terriko