test: re-enable failing tests from #3653 #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3720 +/- ##
==========================================
+ Coverage 79.48% 80.28% +0.79%
==========================================
Files 803 803
Lines 11974 11967 -7
Branches 1603 1603
==========================================
+ Hits 9518 9608 +90
+ Misses 1998 1936 -62
+ Partials 458 423 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
terriko
changed the title
inosmeet
pushed a commit
to inosmeet/cve-bin-tool
that referenced
this pull request
Feb 6, 2024
* test: try re-enabling exploit test * test: re-add test_csv2cve tests * test: re-enable language scanner tests * test: re-enable test_sbom tests
inosmeet
pushed a commit
to inosmeet/cve-bin-tool
that referenced
this pull request
Feb 16, 2024
* test: try re-enabling exploit test * test: re-add test_csv2cve tests * test: re-enable language scanner tests * test: re-enable test_sbom tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3653
I was able to get the tests to fail locally, but it looks like my local database was messed up because OSV had over-written the NVD severity data, causing tests to fail. Refreshing the data has fixed it, but it's possibly because we're having other OSV issues and that data isn't getting loaded. Going to re-enable the tests and make sure nvd is loaded last (so it over-writes any bad data from OSV) but I'll need to keep an eye on this because something bigger is likely wrong with the way our data sources are loading.