Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add PHP launguage specification to docs #3665

Merged
merged 3 commits into from
Jan 3, 2024
Merged

docs: add PHP launguage specification to docs #3665

merged 3 commits into from
Jan 3, 2024

Conversation

Mahhheshh
Copy link
Contributor

closes #3638
The addition of PHP (#2567) support was not documented in the MANUAL.md file.

@Mahhheshh Mahhheshh changed the title feat: add PHP launguage specification to docs docs: add PHP launguage specification to docs Dec 25, 2023
@terriko
Copy link
Contributor

terriko commented Dec 27, 2023

Approved the workflow to run tests. It's likely going to fail some (unrelated) stuff in the linux tests because we have another test issue happening on linux, but please fix any linter issue it finds!

@terriko
Copy link
Contributor

terriko commented Dec 28, 2023

Updating this branch to address the failing tests; will be back to review sometime after it's finished re-running them.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf9afe9) 78.98% compared to head (7efc967) 79.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
+ Coverage   78.98%   79.08%   +0.10%     
==========================================
  Files         797      797              
  Lines       11927    11927              
  Branches     1602     1602              
==========================================
+ Hits         9420     9433      +13     
+ Misses       2075     2055      -20     
- Partials      432      439       +7     
Flag Coverage Δ
longtests 73.73% <ø> (-4.58%) ⬇️
win-longtests 77.13% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mahhheshh
Copy link
Contributor Author

Thank you for the PR update!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're ready to merge. Thank you for the docs (and your patience in fixing our test issues!) and congratulations on your first merged pull request with us!

@terriko terriko merged commit cf67f09 into intel:main Jan 3, 2024
21 checks passed
@Mahhheshh
Copy link
Contributor Author

Thanks A lot @terriko

inosmeet pushed a commit to inosmeet/cve-bin-tool that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add missing description for PHP language checker
3 participants