-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add PHP launguage specification to docs #3665
Conversation
Approved the workflow to run tests. It's likely going to fail some (unrelated) stuff in the linux tests because we have another test issue happening on linux, but please fix any linter issue it finds! |
Updating this branch to address the failing tests; will be back to review sometime after it's finished re-running them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
+ Coverage 78.98% 79.08% +0.10%
==========================================
Files 797 797
Lines 11927 11927
Branches 1602 1602
==========================================
+ Hits 9420 9433 +13
+ Misses 2075 2055 -20
- Partials 432 439 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for the PR update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're ready to merge. Thank you for the docs (and your patience in fixing our test issues!) and congratulations on your first merged pull request with us!
Thanks A lot @terriko |
closes #3638
The addition of PHP (#2567) support was not documented in the MANUAL.md file.