-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Clarifying use of --metrics and epss options #3663
Conversation
@terriko Can you please provide a feedback, so I can further improve my documentation work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes to make this shorter and clearer. Note that I updated your branch to address a test issue, so you should be able to get to the point where all tests pass and this can be merged if you keep the updated branch!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3663 +/- ##
==========================================
+ Coverage 78.98% 79.42% +0.44%
==========================================
Files 797 797
Lines 11927 11927
Branches 1602 1602
==========================================
+ Hits 9420 9473 +53
+ Misses 2075 2022 -53
Partials 432 432
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
@terriko committed the requested changes with updated branch. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now. I'm going to update the branch again to try to fix the tests so this can be merged, but you might have to wait until tomorrow since I'm at the end of my work day!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're set to merge now. Thank you for both the PR and your patience with our test failures!
--metrics
.