-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(README.md): updated options list in README.md #3662
Conversation
Hey @terriko, can you please approve it |
I've approved the tests to run and I'll be back to review more carefully after they've finished. Be warned that there are some tests failing (see #3653) that will not be related to your code, but if you could fix any linter issues found that would be extremely helpful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking promising, but you'll need to add some of the PGP terms to the dictionary here:
https://github.com/intel/cve-bin-tool/blob/main/.github/actions/spelling/allow.txt
@terriko, I have added all the required terms to the dictionary |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3662 +/- ##
==========================================
+ Coverage 76.85% 77.12% +0.27%
==========================================
Files 795 795
Lines 11788 11788
Branches 1372 1372
==========================================
+ Hits 9060 9092 +32
+ Misses 2288 2254 -34
- Partials 440 442 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Re-starting the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're ready to merge! thanks for looking into this one and getting us up to date, and congratulations on your first merged commit with us!
I have updated the options list in README.md by adding the missing options which I got from
cve-bin-tool --help
. Also I have added the links to the MANUAL file for the options which were present in the MANUAL file. Few of the options were not present in the MANUAL file, so I couldn't add the links for those options.fixes #3652