Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README.md): updated options list in README.md #3662

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

DEVESH-N2
Copy link
Contributor

I have updated the options list in README.md by adding the missing options which I got from cve-bin-tool --help . Also I have added the links to the MANUAL file for the options which were present in the MANUAL file. Few of the options were not present in the MANUAL file, so I couldn't add the links for those options.

fixes #3652

@DEVESH-N2
Copy link
Contributor Author

Hey @terriko, can you please approve it

@terriko
Copy link
Contributor

terriko commented Dec 27, 2023

I've approved the tests to run and I'll be back to review more carefully after they've finished. Be warned that there are some tests failing (see #3653) that will not be related to your code, but if you could fix any linter issues found that would be extremely helpful!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking promising, but you'll need to add some of the PGP terms to the dictionary here:
https://github.com/intel/cve-bin-tool/blob/main/.github/actions/spelling/allow.txt

@DEVESH-N2
Copy link
Contributor Author

@terriko, I have added all the required terms to the dictionary

@DEVESH-N2 DEVESH-N2 requested a review from terriko December 28, 2023 19:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4f1271) 76.85% compared to head (fb9436e) 77.12%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3662      +/-   ##
==========================================
+ Coverage   76.85%   77.12%   +0.27%     
==========================================
  Files         795      795              
  Lines       11788    11788              
  Branches     1372     1372              
==========================================
+ Hits         9060     9092      +32     
+ Misses       2288     2254      -34     
- Partials      440      442       +2     
Flag Coverage Δ
win-longtests 77.12% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terriko
Copy link
Contributor

terriko commented Jan 3, 2024

Re-starting the tests.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're ready to merge! thanks for looking into this one and getting us up to date, and congratulations on your first merged commit with us!

@terriko terriko merged commit 7862103 into intel:main Jan 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: update options list in README.md
3 participants