feat: Enable metrics if epss-{percentile,probability} is set #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
changed the title
ffontaine
force-pushed
the
fix-3625
branch
2 times, most recently
from
26f8fce to
cc618a5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3642 +/- ##
==========================================
+ Coverage 77.76% 78.35% +0.58%
==========================================
Files 781 785 +4
Lines 11700 11723 +23
Branches 1369 1369
==========================================
+ Hits 9099 9185 +86
+ Misses 2183 2119 -64
- Partials 418 419 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
terriko
requested changes
Dec 19, 2023
cve_bin_tool/cli.py
Outdated
| @@ -279,13 +279,11 @@ def main(argv=None): | |||
| "--epss-percentile", | |||
| action="store", | |||
| help="minimum epss percentile of CVE range between 0 to 100 to report (default: 0)", | |||
| default=0, | |||
| ) | |||
| output_group.add_argument( | |||
| "--epss-probability", | |||
| action="store", | |||
| help="minimum epss probability of CVE range between 0 to 100 to report (default: 0)", | |||
There was a problem hiding this comment.
Suggested change
| help="minimum epss probability of CVE range between 0 to 100 to report (default: 0)", | |
| help="minimum epss probability of CVE range between 0 to 100 to report", |
Same as above, no default now so help text needed an update.
cve_bin_tool/cli.py
Outdated
| @@ -279,13 +279,11 @@ def main(argv=None): | |||
| "--epss-percentile", | |||
| action="store", | |||
| help="minimum epss percentile of CVE range between 0 to 100 to report (default: 0)", | |||
There was a problem hiding this comment.
Suggested change
| help="minimum epss percentile of CVE range between 0 to 100 to report (default: 0)", | |
| help="minimum epss percentile of CVE range between 0 to 100 to report", |
If we're removing the default to make the logic work better, we should also remove the default shown in help text.
Enable metrics if epss-percentile or epss-probability is set by the user. This commit also fix this following broken logic which allowed negative epss values: if float(args["epss_percentile"]) > 0 or float(args["epss_percentile"]) < 100: replaced by: if float(args["epss_percentile"]) >= 0 and float(args["epss_percentile"]) <= 100: Tentative fix for intel#3625 Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
terriko
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable metrics if epss-percentile or epss-probability is set by the user. This commit also fix this following broken logic which allowed negative epss values:
if float(args["epss_percentile"]) > 0 or float(args["epss_percentile"]) < 100:replaced by:
if float(args["epss_percentile"]) >= 0 and float(args["epss_percentile"]) <= 100:Tentative fix for #3625