Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version_compare: support + in versions #3554

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

perrinjerome
Copy link
Contributor

Fixes #3552

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c656c23) 77.90% compared to head (32975f7) 78.18%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3554      +/-   ##
==========================================
+ Coverage   77.90%   78.18%   +0.28%     
==========================================
  Files         761      761              
  Lines       11568    11571       +3     
  Branches     1359     1359              
==========================================
+ Hits         9012     9047      +35     
+ Misses       2132     2105      -27     
+ Partials      424      419       -5     
Flag Coverage Δ
win-longtests 78.18% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terriko terriko merged commit f99f127 into intel:main Dec 4, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: version compare can't handle + in version numbers
3 participants