fix: improve luajit checker #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve luajit checker to avoid false positive with snort binary which links dynamically with luajit library (and saves the associated version number) Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Codecov Report
@@ Coverage Diff @@
## main #2993 +/- ##
==========================================
+ Coverage 82.09% 82.10% +0.01%
==========================================
Files 714 714
Lines 10983 10983
Branches 1476 1476
==========================================
+ Hits 9016 9018 +2
+ Misses 1585 1583 -2
Partials 382 382
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Not sure what was up with the tests on this run; I'm going to update the branch and re-run them. |
terriko
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve luajit checker to avoid false positive with snort binary which links dynamically with luajit library (and saves the associated version number)