Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: zlib with known vulnerabilities is showing in "products with no identified vulnerabilities " section #3169

Closed
firefive4u opened this issue Jul 19, 2023 · 2 comments · Fixed by #3254
Labels
bug Something isn't working

Comments

@firefive4u
Copy link

When I used this tool to test curl-i386 from https://github.com/moparisthebest/static-curl/releases/tag/v8.1.2, in the console report, I could see that there were some CVEs in Zlib with version 1.2.12.
But when looked into "Products with No Identified Vulnerabilities", Zlib with version 1.2.12 was there. So I am confused, what's the purpose of "Products with No Identified Vulnerabilities" part? Why Zlib with CVEs was listed there?

@terriko
Copy link
Contributor

terriko commented Jul 19, 2023

So first, this sounds like a bug. Something that has vulnerabilities shouldn't appear in that section. I'm guessing we might have introduced something when we updated what's supposed to go in the blank reports? But anyhow, I'm going to tag this as a bug that needs investigation and fixing.

More generally: the "Products with no identified vulnerabilities" section is intended to give people a more complete picture of what was scanned. Otherwise when you get a scan that says no vulnerabilities were found it would be hard to distinguish between a few possibilities:

  1. Everything scanned correctly and no vulnerabilities were found.
  2. The tool couldn't parse some/all of the files supplied and thus never scanned some components.
  3. The tool didn't have checkers that could detect some/all of the components in this package and thus some components were not found or scanned.
  4. The tool had some checkers that didn't detect correctly so the incorrect component was found/scanned.
  5. The user accidentally scanned the wrong directory.

So the idea is to tell people exactly what components were found (even if they had no CVEs!) so you can make sure that it's case 1, and if it's one of the other cases it will hopefully give you enough information to fix the scan or file a bug.

I'm not sure if the right fix for your zlib issue is "make sure things with CVEs don't appear in that section" or "change the name of the section to indicate that it's showing a complete list of what's scanned" (a full list works just as well for those cases above as a list with the vulnerable components removed) but we should figure that out.

@terriko terriko added the bug Something isn't working label Jul 19, 2023
@terriko terriko changed the title Be confused by report bug: zlib with known vulnerabilities is showing in "products with no identified vulnerabilities " section Jul 19, 2023
@ffontaine
Copy link
Contributor

The issue is raised because zlib has two CPE IDs in NVD NIST database:

  • gnu:zlib is used by NVD NIST to tag CVE-2016-9842
  • zlib:zlib is used for all other CVEs

Currently, cve-bin-tool will return gnu:zlib in "Products with No Identified Vulnerabilities" if zlib is found but not affected by CVE-2016-9842 (i.e. zlib >= 1.2.9).

Perhaps the name of the section could be changed or a note could be added to better explain those corner cases. An other option would be to better handle products with multiple CPE IDs (e.g. zlib but also acpid, apcupsd, asterisk, etc.) inside cve-bin-tool but this is not easy.

ffontaine added a commit to ffontaine/cve-bin-tool that referenced this issue Aug 15, 2023
Currently, cve-bin-tool will return gnu:zlib in "Products with No
Identified Vulnerabilities" if zlib is found but not affected by
CVE-2016-9842 (i.e. zlib >= 1.2.9) because NVD NIST database contains
two CPE IDs for zlib (gnu:zlib and zlib:zlib)

With this update, product with multiple vendors will not be displayed
under above section if a CVE is found with one of the vendor.

Fix intel#3169

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine added a commit to ffontaine/cve-bin-tool that referenced this issue Aug 15, 2023
Currently, cve-bin-tool will return gnu:zlib in "Products with No
Identified Vulnerabilities" if zlib is found but not affected by
CVE-2016-9842 (i.e. zlib >= 1.2.9) because NVD NIST database contains
two CPE IDs for zlib (gnu:zlib and zlib:zlib)

With this update, product with multiple vendors will not be displayed
under above section if a CVE is found with one of the vendor.

Fix intel#3169

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine added a commit to ffontaine/cve-bin-tool that referenced this issue Aug 15, 2023
Currently, cve-bin-tool will return gnu:zlib in "Products with No
Identified Vulnerabilities" if zlib is found but not affected by
CVE-2016-9842 (i.e. zlib >= 1.2.9) because NVD NIST database contains
two CPE IDs for zlib (gnu:zlib and zlib:zlib)

With this update, product with multiple vendors will not be displayed
under above section if a CVE is found with one of the vendor.

Fix intel#3169

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
terriko pushed a commit that referenced this issue Aug 17, 2023
Currently, cve-bin-tool will return gnu:zlib in "Products with No
Identified Vulnerabilities" if zlib is found but not affected by
CVE-2016-9842 (i.e. zlib >= 1.2.9) because NVD NIST database contains
two CPE IDs for zlib (gnu:zlib and zlib:zlib)

With this update, product with multiple vendors will not be displayed
under above section if a CVE is found with one of the vendor.

Fix #3169

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants