Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.0 release preparation: always try to enable 'SystemdCgroup = true' for tests with containerd. #730

Merged

Conversation

klihub
Copy link
Contributor

@klihub klihub commented Oct 5, 2021

distro: always try setting 'SystemdCgroup = true' for containerd.

@klihub klihub force-pushed the release/prepare/0.6.0/enable-systemd-cgroup branch from 1ce0062 to 5a4dfda Compare October 5, 2021 11:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #730 (5a4dfda) into master (3730f3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   37.64%   37.64%           
=======================================
  Files          53       53           
  Lines        7889     7889           
=======================================
  Hits         2970     2970           
  Misses       4643     4643           
  Partials      276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3730f3d...5a4dfda. Read the comment docs.

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if it works.

In retrospect we really should've used ansible or smth for these 😇

@klihub klihub marked this pull request as ready for review October 5, 2021 13:02
@klihub
Copy link
Contributor Author

klihub commented Oct 5, 2021

lgtm, if it works.

In retrospect we really should've used ansible or smth for these

Exactly what I said to you guys a month or so ago during one of our office days. So I can't claim to disagree...

@klihub klihub merged commit fbf45f2 into intel:master Oct 5, 2021
@klihub klihub deleted the release/prepare/0.6.0/enable-systemd-cgroup branch October 5, 2021 13:05
@klihub klihub mentioned this pull request Oct 5, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants