-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6.0 release preparation: use distinctive VM names for packaging tests. #728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like #725 should be merged first. But lgtm after that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9a67d76
to
ec7f212
Compare
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=======================================
Coverage 37.64% 37.64%
=======================================
Files 53 53
Lines 7889 7889
=======================================
Hits 2970 2970
Misses 4643 4643
Partials 276 276 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase on top of latest master -> then let's merge this
Use a unique prefix for all VMs created for testing distro package installation. This should prevent ruining or inter- fering otherwise with other test VMs folks might have in a non-transient state for longer term debugging sessions.
ec7f212
to
7a42ad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e2e: name all packaging test VMs distinctively.
Use a unique prefix for all VMs created for testing distro
package installation. This should prevent ruining or inter-
fering otherwise with other test VMs folks might have in a
non-transient state for longer term debugging sessions.