Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.0 release preparation: use distinctive VM names for packaging tests. #728

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

klihub
Copy link
Contributor

@klihub klihub commented Oct 4, 2021

e2e: name all packaging test VMs distinctively.

Use a unique prefix for all VMs created for testing distro
package installation. This should prevent ruining or inter-
fering otherwise with other test VMs folks might have in a
non-transient state for longer term debugging sessions.

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #725 should be merged first. But lgtm after that

askervin
askervin previously approved these changes Oct 5, 2021
Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #728 (ec7f212) into master (feda165) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   37.64%   37.64%           
=======================================
  Files          53       53           
  Lines        7889     7889           
=======================================
  Hits         2970     2970           
  Misses       4643     4643           
  Partials      276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feda165...ec7f212. Read the comment docs.

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase on top of latest master -> then let's merge this

Use a unique prefix for all VMs created for testing distro
package installation. This should prevent ruining or inter-
fering otherwise with other test VMs folks might have in a
non-transient state for longer term debugging sessions.
@klihub klihub force-pushed the release/prepare/0.6.0/pkgtest-vms branch from ec7f212 to 7a42ad6 Compare October 5, 2021 10:53
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub merged commit 3730f3d into intel:master Oct 5, 2021
@klihub klihub deleted the release/prepare/0.6.0/pkgtest-vms branch October 5, 2021 11:02
@klihub klihub mentioned this pull request Oct 5, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants