-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with goresctrl #711
Conversation
fb94289
to
a4040f1
Compare
a4040f1
to
ed0c543
Compare
|
ed0c543
to
4d24005
Compare
|
a889386
to
88db640
Compare
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
- Coverage 37.70% 37.64% -0.06%
==========================================
Files 53 53
Lines 7877 7889 +12
==========================================
Hits 2970 2970
- Misses 4631 4643 +12
Partials 276 276
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have spotted a few differences I don't understand, wrt. fully identical code before vs. after these changes. Apart from those/once I understand them, this LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a diffstat 😅 One small suggestion, otherwise looks good.
Also, I'd suggest to squash the changes to go.{mod,sum}
into one single commit.
88db640
to
f70aa5b
Compare
New dependency versions updated. Use goresctrl v0.2.0 which contains the needed SST modifications.
Use goresctrl code for SST. This means that we can then remove duplicate code from cri-resource-manager repo. Fixes intel#708
Add more standardized logger interface functions so that cri-rm can use the goresctrl logger API.
f70aa5b
to
4f9ce60
Compare
Updated according to comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This depends on the changes in intel/goresctrl#75