Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: enable reinstalling pretty much everything on VMs #689

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

askervin
Copy link
Contributor

@askervin askervin commented Aug 5, 2021

  • If a reinstall variable is set for any package, it will be forced to reinstall on the system.
  • OpenSUSE / SLES install runc from Virtualization_containers.
  • Reinstalling k8s means scrapping and recreating the cluster on VM -- in addition to reinstalling kubeadm, kubectl and kubelet.
  • Refactor: get rid of screen-install-k8s.

Implemented on top of #688.

Implements suggested reinstall feature in issue #686 .

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #689 (05af4e5) into master (73524c4) will increase coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   36.87%   37.70%   +0.82%     
==========================================
  Files          53       53              
  Lines        6722     7877    +1155     
==========================================
+ Hits         2479     2970     +491     
- Misses       3984     4631     +647     
- Partials      259      276      +17     
Impacted Files Coverage Δ
...rce-manager/policy/builtin/topology-aware/flags.go 66.66% <0.00%> (-6.07%) ⬇️
pkg/log/default.go 23.07% <0.00%> (-5.50%) ⬇️
pkg/cgroups/cgrouppath.go 33.33% <0.00%> (-4.17%) ⬇️
pkg/log/ratelimit.go 52.17% <0.00%> (-3.09%) ⬇️
...manager/policy/builtin/podpools/podpools-policy.go 24.21% <0.00%> (-1.69%) ⬇️
pkg/cri/resource-manager/cache/affinity.go 30.17% <0.00%> (-1.41%) ⬇️
...rce-manager/policy/builtin/topology-aware/cache.go 35.33% <0.00%> (-0.70%) ⬇️
...ource-manager/control/page-migrate/page-migrate.go 9.75% <0.00%> (-0.08%) ⬇️
pkg/cgroups/cgroupblkio.go 84.51% <0.00%> (-0.04%) ⬇️
pkg/log/signal.go 0.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73524c4...05af4e5. Read the comment docs.

- If a reinstall variable is set for any package, it will be
  forced to reinstall on the system.
- OpenSUSE / SLES install runc from Virtualization_containers.
- Reinstalling k8s means scrapping and recreating the cluster on VM
  in addition to reinstalling kubeadm, kubectl and kubelet.
- Refactor: get rid of screen-install-k8s.
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub merged commit 15176d6 into intel:master Aug 12, 2021
@klihub klihub mentioned this pull request Oct 5, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants