e2e: support annotations in common pod templates #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
ipuustin,
kad,
klihub,
marquiz and
mythi
as code owners
klihub
reviewed
Jul 2, 2021
Labels and annotations can be added to besteffort, burstable and guaranteed pods through ANN[0-9] and LABEL[0-9] environment variables. Example: LABEL0='mylbl: "myval"' ANN0='my.key: "myvalue"' create besteffort
askervin
force-pushed
the
5DU_e2e_pod_template_annotations
branch
from
d04d8b3
to
8247025
Compare
|
Good idea. Support for LABEL0=... LABEL1=.... included to this patch, commit message rephrased. |
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
=======================================
Coverage 36.87% 36.87%
=======================================
Files 53 53
Lines 6722 6722
=======================================
Hits 2479 2479
Misses 3984 3984
Partials 259 259 Continue to review full report at Codecov.
|
klihub
approved these changes
Jul 5, 2021
marquiz
reviewed
Jul 5, 2021
There was a problem hiding this comment.
Looks good. Just a small note about the naming. I'd prefer using a non-abbreviated name ANNOTATION0 instead of ANN0. Especially as we now have LABEL0 (and not LAB0 for example).
I can live with the abbreviated naming too, if you want to merge this in it's current form, though 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations can be added to besteffort, burstable and guaranteed pods
through ANN[0-9] environment variables. Example:
CPU=500m MEM=64M ANN0='my.key: "myvalue"' create guaranteed