Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Fix govm installation documentation #662

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

jukkar
Copy link
Contributor

@jukkar jukkar commented Jun 28, 2021

The installation of govm needs to be done slightly differently
when using go 1.16

The installation of govm needs to be done slightly differently
when using go 1.16
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #662 (86c7fce) into master (0706260) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   36.87%   36.87%           
=======================================
  Files          53       53           
  Lines        6722     6722           
=======================================
  Hits         2479     2479           
  Misses       3984     3984           
  Partials      259      259           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0706260...86c7fce. Read the comment docs.

@askervin
Copy link
Contributor

Verified on:

  • ubuntu 20.04 with go 1.13
  • ubuntu 20.04 with go 1.16
  • fedora 33 with go 1.15

govm binary and govm:latest image are built correctly.

Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good and works fine!

Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub merged commit 213e4ff into intel:master Jul 2, 2021
@klihub klihub mentioned this pull request Oct 5, 2021
25 tasks
@jukkar jukkar deleted the e2e-test-install-doc-fix branch March 7, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants