Enable fixing balloon instances to hardcoded CPUs and memories for benchmarking #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
kad,
klihub,
marquiz,
mythi,
jukkar and
fmuyassarov
as code owners
jukkar
reviewed
Apr 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
==========================================
- Coverage 31.86% 31.85% -0.01%
==========================================
Files 65 66 +1
Lines 9835 9872 +37
==========================================
+ Hits 3134 3145 +11
- Misses 6411 6437 +26
Partials 290 290
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BalloonInstances configuration sets constraints and overrides on CPU allocation and memory pinning of individual balloon instances. This feature is useful for benchmarking well-known hardware topology with well-known sequences of workload deployments. However, using this feature under other circumstances is prone to errors and likely to lead into situations where pods that have been scheduled on a node cannot be run. Therefore enabling this feature requires building cri-resmgr with "benchmarking" build tag (make BENCHMARKING=1).
askervin
force-pushed
the
5OV_balloon_instances
branch
from
b17ed04 to
4c62b5d
Compare
|
Thanks @jukkar, good point. I added both "why" and "why not" reasoning on the commit that introduces |
|
For real use (instead of manually tuned benchmarking) we should do something similar to preferCloseToDevices like in containers/nri-plugins#203. |
|
Let's close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches add support for
BalloonInstancesconfiguration. It enables setting constraints and overrides on individual balloon instances regarding CPU allocation and memory pinning.This feature is useful for benchmarking well-known hardware under different loads. However, using this feature makes the balloons policy configuration totally inapplicable to heterogenous clusters and very prone to configuration errors. These issues are likely to manifest themselves by not being able to run pods that have been scheduled on a node. Therefore this feature is not available by default, but only if
cri-resmgris built withbenchmarkingbuild tag (ormake BENCHMARKING=1).