migtd: abstract vmcall operations into VmcallService
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumer of this structure may have the requirement to read the data in slice rather than deserializing bytes into struct directly with `read_data()` method. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
There are several duplicate code blocks for setting up buffers, executing and parsing return values for `TDVMCALL<Service>`. Here the vmcall operations are abstracted into a struct `VmcallService` to eliminite the duplicate code. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several duplicate code blocks for setting up buffers, executing and parsing return values for
TDVMCALL<Service>.Here the vmcall operations are abstracted into a struct
VmcallServiceto eliminite the duplicate code.