Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trait UnwrapOrSgxErrorUnexpected #413

Closed
Tracked by #256
clangenb opened this issue Sep 22, 2021 · 0 comments · Fixed by #539
Closed
Tracked by #256

Remove trait UnwrapOrSgxErrorUnexpected #413

clangenb opened this issue Sep 22, 2021 · 0 comments · Fixed by #539
Assignees

Comments

@clangenb
Copy link
Contributor

This is a trait I introduced a long time ago without knowledge of how to handle errors in rust correctly. We should remove this unidiomatic trait bound and use the enclave error instead because:

  • When logging the error with sgx_error_with_log, the error source is displayed as being in utils wich is not true. So important debugging information is hidden.
  • it is unidiomatic.
  • it is verbose, i.e., we need to call sgx_error()? compared to ?.
@clangenb clangenb mentioned this issue Sep 22, 2021
14 tasks
@gaudenzkessler gaudenzkessler changed the title Remove trait UnwrapOrSgxErrorUnexpexted Remove trait UnwrapOrSgxErrorUnexpected Nov 29, 2021
@gaudenzkessler gaudenzkessler self-assigned this Nov 30, 2021
clangenb pushed a commit that referenced this issue Dec 1, 2021
Co-authored-by: Gaudenz Kessler <gaudenz.kessler@scs.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants