Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polkadot-v0.9.29 #168

Merged
merged 20 commits into from
Oct 26, 2022
Merged

Update polkadot-v0.9.29 #168

merged 20 commits into from
Oct 26, 2022

Conversation

OverOrion
Copy link
Contributor

No description provided.

Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the comment.

@clangenb That's for you to decide: Do you still want to have a runtime upgrade tested before merging something, or will the test on Rococo suffice?

pallet-sidechain = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "polkadot-v0.9.27" }
pallet-teeracle = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "polkadot-v0.9.27" }
pallet-teerex = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "polkadot-v0.9.27" }
pallet-claims = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "szp/polkadot-v0.9.29" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pallet-claims = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "szp/polkadot-v0.9.29" }
pallet-claims = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "polkadot-v0.9.29" }

and for the others below as well

@OverOrion OverOrion marked this pull request as ready for review October 20, 2022 12:10
@haerdib
Copy link
Contributor

haerdib commented Oct 20, 2022

Ah, sorry, I forgot to check for the scripts: Can you update the launch scripts (e.g. zombienet and polkadot-launch) to v0.9.29 as well? Can be easily done via search and replace.

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is fine for me, we should only test the runtime upgrade, when we actually perform one.

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue. Please bump the spec version of the shell-runtime as well. :)

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bump the shell-runtime spec_version here please:

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@@ -42,7 +42,6 @@ name = "integritee-collator02"
command = "./target/release/integritee-collator"
ws_port = 9995

#this is not working !!!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@clangenb clangenb merged commit c9cd8df into master Oct 26, 2022
@clangenb clangenb deleted the szp/polkadot-v0.9.29 branch August 25, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants