add hardcoded chain spec: shell_kusama_lease2
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
reviewed
Sep 6, 2022
There was a problem hiding this comment.
Once we hand over this slot to our main parachain, the genesis shell_kusama_lease2will not be necessary anymore. There is no strict need for hardcoding this into our binaries as we ourselves will be the only ones running nodes (if necessary at all), so a json spec would do too. So I even think you don't need an extra release of our parachain for this
|
I agree that this will not be necessary in the future and that a plain json is enough. I just want to be as explicit as possible to minimize the chances of a genesis mismatch. Would you suggest that plain wiki documentation is enough? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be the chain-spec that we register for the next slot.