Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated weights: Benchmark on DO droplet #91

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Updated weights: Benchmark on DO droplet #91

merged 5 commits into from
Nov 11, 2021

Conversation

echevrier
Copy link
Contributor

No description provided.

@echevrier echevrier linked an issue Nov 11, 2021 that may be closed by this pull request
repeat benchamrk on the DO droplet #65
Closed
@echevrier echevrier requested a review from haerdib November 11, 2021 09:36
haerdib
haerdib approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks to both of you!

clangenb
clangenb requested changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update here the specifications that were used to obtain the benchmark:

integritee-node/runtime/src/weights/mod.rs

Line 3 in fbebb0c

//! The current weights have been obtained with the following reference hardware:

Also add these specifications to the readme and extend the benchmark section so it looks like the encointer-parachain's.

https://github.com/encointer/encointer-parachain#benchmark-the-runtimes

@echevrier echevrier requested a review from clangenb November 11, 2021 10:43
clangenb
clangenb approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for updating the readme.

@clangenb clangenb merged commit 4323a56 into master Nov 11, 2021
@gaudenzkessler gaudenzkessler deleted the Fix_benchmarks_for-teeracle branch November 19, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

@haerdib haerdib haerdib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repeat benchamrk on the DO droplet
4 participants
@echevrier @clangenb @haerdib @mosonyi