-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support rule type code_scanning #2436
feat: Support rule type code_scanning #2436
Conversation
… and github_repository_ruleset
@ihor-hrytskiv would it be possible to split out the |
Thank @kfcampbell for the suggestion, this is my PR |
It's awesome to run into something you are working on @kfcampbell! I wanted to check on what is the status of this pull request? I ran a cross it when I was trying to built out some terraform for a client and ran into this missing feature in the code that is blocking me from proceeding. I can shelf the code for now since I am only dealing with one organization at the moment, but wondering when this feature may become available since I will be supporting larger enterprise efforts in the near future where enabling the code scan tool is a requirement. |
@ihor-hrytskiv I merged your other PR and gave a shot at a merge from there into here. It looks like there's some issues with deprecated routes and linting errors, though that could be my fault from the merge. Thoughts? |
@kfcampbell fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ihor-hrytskiv thank you!
* feat: support rule type code_scanning for github_organization_ruleset and github_repository_ruleset * feat: docs * feat: docs * chore: remove tag protection endpoint --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Support rule type code_scanning for github_organization_ruleset and github_repository_ruleset
Resolves #2310
Example:
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!