Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow filtering on permission in repo collaborator datasource #2382

Merged

Conversation

felixlut
Copy link
Contributor

@felixlut felixlut commented Sep 6, 2024

Resolves #2381


Before the change?

  • It was not possible to filter on permission for the github_collaborators datasource before this change

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No
    • Worth noting is that I've changed the internal ID of the datasource to include the new permission argument if it is set here. I don't think this counts as a breaking change since the ID only changes if the ID is the permission is actually set. Omitting it will default to the same ID as before this change

@felixlut felixlut marked this pull request as ready for review September 6, 2024 12:47
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@kfcampbell kfcampbell merged commit af9cf3d into integrations:main Sep 9, 2024
3 checks passed
@felixlut felixlut deleted the data_repo_colaborator_permission_filer branch September 24, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: github_collaborators data_source should allow filtering based on permission
2 participants