Rate limit #2345
Merged
Rate limit #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the tests prior to making changes 2 issues were seen 1) With a setting to enable vulnerability alerts the tests failed, adding them to be on in these tests doesn't impact the results and allows others in the same position to run the tests. 2) The overwrte tests did not set attributes that were being asserted, adding the attribures allow the test to pass. Not sure how these previously passed.
kfcampbell
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2344
Before the change?
This change stops the file from being removed from the state when the operation is rate limited, I am unsure if we should also handle 5xx here too.
After the change?
The operation fails with an error due to rate limiting leaving the file in the state.
Pull request checklist
I don't believe I can add an acceptance test for this, there don't appear to be any unit level tests so have not added anything. Happy to look at this on your guidance.
Does this introduce a breaking change?
Please see our docs on breaking changes to help!