Skip to content

Conversation

Nmishin
Copy link
Contributor

@Nmishin Nmishin commented Nov 3, 2023

Resolves #1967

Before the change?

  • We can't manage "Prevent self-review" option

After the change?

  • We can manage "Prevent self-review" option

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@kfcampbell
Copy link
Contributor

#2011 will unblock this PR.

@nickfloyd nickfloyd added the Type: Breaking change Used to note any change that requires a major version bump label Dec 11, 2023
@andreas-aman
Copy link

I saw #2011 has been superseeded by #2081 that has been merged. Does this mean this PR can be unblocked?

@Nmishin
Copy link
Contributor Author

Nmishin commented Jan 9, 2024

@kfcampbell MR updated, could you please review

Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming integration tests are passing for me. Thank you for the contribution!

@kfcampbell kfcampbell merged commit dbda378 into integrations:main Jan 19, 2024
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
…t resource (integrations#2000)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking change Used to note any change that requires a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add prevent_self_review boolean to the github_repository_environment resource
4 participants