upgrade go-github to v55 #1894
Merged
upgrade go-github to v55 #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-sama
force-pushed
the
upgrade-go-github-v55
branch
from
e50b6de to
f7e9899
Compare
|
On second thoughts, although it's just a deprecation and lint override can be done, I'll take some time to update the client constructor to use the new pattern tonight. |
nickfloyd
approved these changes
Sep 15, 2023
nickfloyd
added
the
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1886 (Partially, as mentioned in #1887)
Before the change?
go-githubis on v54.organization_ruleset.conditions.repository_nameomits empty fields that are required on the GitHub API.After the change?
go-githubis on v55.organization_ruleset.conditions.repository_nameis fixed.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
This shouldn't be a breaking change, the only breaking change mentioned on the new release of
go-githubis related to Security Advisory Events, where the changes made don't seem to affect anything used by the provider.