Do not change allow_update_branch/has_downloads on archived repos #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid causing a permanent `plan` diff by attempting to change attributes that can no longer be modified if a repository is archived. Fixes #1793.
doonga
referenced
this pull request
in doonga/greyrock-ops
Jul 15, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | minor | `5.30.1` -> `5.31.0` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v5.31.0`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v5.31.0) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v5.30.1...v5.31.0) #### What's Changed - build(deps): bump golang.org/x/oauth2 from 0.9.0 to 0.10.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/1785](https://togithub.com/integrations/terraform-provider-github/pull/1785) - 💅 Typo in docs by [@​nmacri](https://togithub.com/nmacri) in [https://github.com/integrations/terraform-provider-github/pull/1789](https://togithub.com/integrations/terraform-provider-github/pull/1789) - Attempted fix for [#​1657](https://togithub.com/integrations/terraform-provider-github/issues/1657) by [@​yaakov-h](https://togithub.com/yaakov-h) in [https://github.com/integrations/terraform-provider-github/pull/1774](https://togithub.com/integrations/terraform-provider-github/pull/1774) - Do not change allow_update_branch/has_downloads on archived repos by [@​kristian-lesko](https://togithub.com/kristian-lesko) in [https://github.com/integrations/terraform-provider-github/pull/1795](https://togithub.com/integrations/terraform-provider-github/pull/1795) - feat: add ability to downgrade membership when `github_membership` is destroyed by [@​jsifuentes](https://togithub.com/jsifuentes) in [https://github.com/integrations/terraform-provider-github/pull/1783](https://togithub.com/integrations/terraform-provider-github/pull/1783) #### New Contributors - [@​nmacri](https://togithub.com/nmacri) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1789](https://togithub.com/integrations/terraform-provider-github/pull/1789) - [@​yaakov-h](https://togithub.com/yaakov-h) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1774](https://togithub.com/integrations/terraform-provider-github/pull/1774) **Full Changelog**: integrations/terraform-provider-github@v5.30.1...v5.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjUiLCJ1cGRhdGVkSW5WZXIiOiIzNi44LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: greyrock-bot <112729691+greyrock-bot[bot]@users.noreply.github.com>
jsifuentes
pushed a commit
to jsifuentes/terraform-provider-github
that referenced
this pull request
Jul 17, 2023
…tegrations#1795) Avoid causing a permanent `plan` diff by attempting to change attributes that can no longer be modified if a repository is archived. Fixes integrations#1793.
felixlut
pushed a commit
to felixlut/terraform-provider-github
that referenced
this pull request
Jul 22, 2023
…tegrations#1795) Avoid causing a permanent `plan` diff by attempting to change attributes that can no longer be modified if a repository is archived. Fixes integrations#1793.
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…tegrations#1795) Avoid causing a permanent `plan` diff by attempting to change attributes that can no longer be modified if a repository is archived. Fixes integrations#1793.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid causing a permanent
plandiff by attempting to change attributes that can no longer be modified if a repository is archived.Resolves #1793.
Behavior
Before the change?
The
has_downloadsandallow_update_branchattributes are attempted to be changed on archived repositories, which silently succeeds but doesn't actually change anything (since it's not allowed if a repository is archived). This causes a permanent configuration drift to be reported byterraform planin some cases.After the change?
The
has_downloadsandallow_update_branchattributes are only set on repositories that are not archived.Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance