Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Ability to import repository secrets #1763

Merged
merged 2 commits into from
Jun 28, 2023
Merged

[FEAT]: Ability to import repository secrets #1763

merged 2 commits into from
Jun 28, 2023

Conversation

KenSpur
Copy link
Contributor

@KenSpur KenSpur commented Jun 28, 2023 •
edited
Loading

Resolves #1761

Behavior

Before the change?

Not able to import secrets for:

  • github_actions_secret
  • github_codespaces_secret
  • github_dependabot_secret

After the change?

  • Able to import above secrets

Other information

  • /

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@KenSpur
Copy link
Contributor Author

KenSpur commented Jun 28, 2023

Ready for review/merge!

kfcampbell
kfcampbell approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @KenSpur!

@kfcampbell kfcampbell merged commit c7a1a70 into integrations:main Jun 28, 2023
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@KenSpur
[FEAT]: Ability to import repository secrets (integrations#1763)
120924c 
* add ability to import for actions/codespaces/dependabot secrets

* update documentation
This was referenced Nov 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bateller bateller bateller approved these changes

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Ability to import repository secrets
3 participants
@KenSpur @bateller @kfcampbell