-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resourceGithubDependabotOrganizationSecretCreateOrUpdate
#1759
Merged
kfcampbell
merged 1 commit into
integrations:main
from
OpenSourceProjects:fix-regression
Jun 27, 2023
Merged
Fix resourceGithubDependabotOrganizationSecretCreateOrUpdate
#1759
kfcampbell
merged 1 commit into
integrations:main
from
OpenSourceProjects:fix-regression
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankywahl
commented
Jun 27, 2023
Fixes a regression used when trying to create/update a dependabot organization secret. List is an `int` so cannot be cast to a different type. We therefore double convert it. There was a regression introduced by version 5.27. This happened as the go-github client moved over to using int64 as ids in v53.0.0 ```hcl terraform { required_providers { github = { source = "integrations/github" version = "5.27.0" } } } provider "github" { owner = var.owner } variable "owner" { type = string } resource "github_repository" "example" { name = "example" description = "My awesome codebase" visibility = "public" } resource "github_dependabot_organization_secret" "example" { secret_name = "example" visibility = "selected" plaintext_value = "anything" selected_repository_ids = [ github_repository.example.repo_id, ] } ```
b56d4dc
to
8c12ad6
Compare
kfcampbell
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
doonga
referenced
this pull request
in doonga/greyrock-ops
Jun 29, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | minor | `5.28.1` -> `5.29.0` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v5.29.0`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v5.29.0) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v5.28.1...v5.29.0) #### What's Changed - fix: support team slug in github_team_membership by [@​kristian-lesko](https://togithub.com/kristian-lesko) in [https://github.com/integrations/terraform-provider-github/pull/1751](https://togithub.com/integrations/terraform-provider-github/pull/1751) - Fixes accidental deletion of Repository resource from state by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/integrations/terraform-provider-github/pull/1750](https://togithub.com/integrations/terraform-provider-github/pull/1750) - feat: Add GitHub Organization Custom Role Resource and Data Source by [@​cailen](https://togithub.com/cailen) in [https://github.com/integrations/terraform-provider-github/pull/1700](https://togithub.com/integrations/terraform-provider-github/pull/1700) - Fix typo in deployment branch policy import by [@​bpaquet](https://togithub.com/bpaquet) in [https://github.com/integrations/terraform-provider-github/pull/1758](https://togithub.com/integrations/terraform-provider-github/pull/1758) - Fix `resourceGithubDependabotOrganizationSecretCreateOrUpdate` by [@​frankywahl](https://togithub.com/frankywahl) in [https://github.com/integrations/terraform-provider-github/pull/1759](https://togithub.com/integrations/terraform-provider-github/pull/1759) - \[Bug]: Renaming github_repository doesn't taint full_name attribute by [@​KenSpur](https://togithub.com/KenSpur) in [https://github.com/integrations/terraform-provider-github/pull/1756](https://togithub.com/integrations/terraform-provider-github/pull/1756) - feat: Ability to Manage Codespaces Secrets by [@​KenSpur](https://togithub.com/KenSpur) in [https://github.com/integrations/terraform-provider-github/pull/1729](https://togithub.com/integrations/terraform-provider-github/pull/1729) #### New Contributors - [@​kristian-lesko](https://togithub.com/kristian-lesko) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1751](https://togithub.com/integrations/terraform-provider-github/pull/1751) - [@​t0yv0](https://togithub.com/t0yv0) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1750](https://togithub.com/integrations/terraform-provider-github/pull/1750) - [@​cailen](https://togithub.com/cailen) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1700](https://togithub.com/integrations/terraform-provider-github/pull/1700) - [@​frankywahl](https://togithub.com/frankywahl) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1759](https://togithub.com/integrations/terraform-provider-github/pull/1759) - [@​KenSpur](https://togithub.com/KenSpur) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1756](https://togithub.com/integrations/terraform-provider-github/pull/1756) **Full Changelog**: integrations/terraform-provider-github@v5.28.1...v5.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMCIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…rations#1759) Fixes a regression used when trying to create/update a dependabot organization secret. List is an `int` so cannot be cast to a different type. We therefore double convert it. There was a regression introduced by version 5.27. This happened as the go-github client moved over to using int64 as ids in v53.0.0 ```hcl terraform { required_providers { github = { source = "integrations/github" version = "5.27.0" } } } provider "github" { owner = var.owner } variable "owner" { type = string } resource "github_repository" "example" { name = "example" description = "My awesome codebase" visibility = "public" } resource "github_dependabot_organization_secret" "example" { secret_name = "example" visibility = "selected" plaintext_value = "anything" selected_repository_ids = [ github_repository.example.repo_id, ] } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression used when trying to create/update a dependabot organization secret. List is an
int
so cannot be cast to a different type. We therefore double convert it.There was a regression introduced by version 5.27. This happened as the go-github client moved over to using int64 as ids in v53.0.0
Resolves #1746
Pull request checklist
Does this introduce a breaking change?
It should fix an issue after the provider get upgraded.
Notes:
CreateOrUpdateOrgSecret
regression introduced in v53 google/go-github#2817 being released (and client updated)