[Bug]: Repository name updates break dependent repository secrets #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review/merge! |
kfcampbell
reviewed
Jun 28, 2023
| @@ -16,13 +16,13 @@ func resourceGithubActionsSecret() *schema.Resource { | |||
| return &schema.Resource{ | |||
| Create: resourceGithubActionsSecretCreateOrUpdate, | |||
| Read: resourceGithubActionsSecretRead, | |||
| Update: resourceGithubActionsSecretCreateOrUpdate, | |||
There was a problem hiding this comment.
Can you explain why removing the update and adding ForceNew solves this issue?
There was a problem hiding this comment.
The Resource Id is made up of the repository and secret_name as a TwoPartID which should be immutable if im not mistaken.
While the update is removed because all properties have forcenew or computed (terraform will complain about it if its left in).
There was a problem hiding this comment.
github/resource_github_actions_environment_secret.go seems to be similar
kfcampbell
approved these changes
Jun 28, 2023
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…tegrations#1754) * fix rename issue & add tests * fix rename issue & add tests * fix rename issue & add tests * remove main.tf --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1753
Behavior
See issure #1753 .
Other information
github_codespaces_secretAdditional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance