Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required/optional for security_and_analysis fields in docs to match the code #1504

Conversation

danielpops
Copy link
Contributor

@danielpops danielpops commented Jan 21, 2023

Resolves #1503


Behavior

Before the change?

Docs don't match the code 🚫

After the change?

Docs match the code ✅

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

No

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

Pull request type

Please add the corresponding label for change this PR introduces:

  • Updates to docs or samples: Type: Documentation

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kfcampbell kfcampbell merged commit ff50f85 into integrations:main Feb 3, 2023
@jtgrohn
Copy link
Contributor

jtgrohn commented Feb 6, 2023

Good catch @danielpops!

reedloden pushed a commit to reedloden/terraform-provider-github that referenced this pull request Jun 14, 2023
…match code (integrations#1504)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
…match code (integrations#1504)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS]: Optional/required incorrect for security_and_analysis fields
3 participants