Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for organization security managers #1371

Merged
merged 6 commits into from
Nov 28, 2022

Conversation

jeremyhayes
Copy link
Contributor

@jeremyhayes jeremyhayes commented Nov 17, 2022

Resolves #1210


Behavior

Before the change?

Users cannot manage security manager teams for their organizations.

After the change?

Users CAN manage security manager teams for their organizations.

Template would look similar to:

resource "github_team" "some_team" {
  name        = "SomeTeam"
  description = "Some cool team"
}
resource "github_organization_security_manager" "some_team" {
  team_slug = github_team.some_team.slug
}

Other information

  • n/a

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@jeremyhayes jeremyhayes changed the title Org security managers Add support for organization security managers Nov 17, 2022
@jeremyhayes jeremyhayes marked this pull request as ready for review November 17, 2022 22:45
@jeremyhayes
Copy link
Contributor Author

jeremyhayes commented Nov 17, 2022

Please add the corresponding label for change this PR introduces:

I think a maintainer will need to add the Type: Feature label.

@kfcampbell kfcampbell added the Type: Feature New feature or request label Nov 28, 2022
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that acceptance tests are passing for me locally. Thank you for the contribution! I love the docs and testing updates.

@kfcampbell kfcampbell merged commit 6493436 into integrations:main Nov 28, 2022
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
* add org security managers resource

* log error on too many security managers

* add default state import by team id

* add security manager resource docs

* Add missing error check

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
* add org security managers resource

* log error on too many security managers

* add default state import by team id

* add security manager resource docs

* Add missing error check

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] support for the Github "Security Managers" feature
2 participants