-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting owner in anonymous mode #1029
Allow setting owner in anonymous mode #1029
Conversation
cc @Olin-Vorechovsky I'd rather do this than error if there's no token present, since there's a lot of valid use cases for the provider without auth configured IMO. Thoughts? |
I think this is a worthwhile change and since it's not breaking backwards compatibility, I've added it to a future milestone for release. |
@jcudit let's talk about this in the next week or two! |
👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the |
I had forgotten about this! I think this is still relevant and should be merged. |
Resolves regressions integrations#2008 and integrations#2014 introduced in integrations#1029 Signed-off-by: Marco Nenciarini <mnencia@kcore.it> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Fixes #647.
The provider currently doesn't respect any ownership configuration when running in anonymous mode. This is annoying because it blocks all kinds of uses, for example data sources retrieving public repos.
This PR makes a small change to respect ownership in anonymous mode, and now those data sources work!