Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During Runner Group Update selected repositories set to empty list #967

Closed
Vladyslav-Miletskyi opened this issue Nov 4, 2021 · 3 comments
Labels
r/actions_runner_group Type: Bug Something isn't working as documented

Comments

@Vladyslav-Miletskyi
Copy link
Contributor

During Group creation everything is OK, but update sets allowed repositories to None.

Terraform Version

Independent of terraform version.
Tested with 4.17.0 provider

Affected Resource(s)

  • github_actions_runner_group

Terraform Configuration Files

resource "github_actions_runner_group" "project" {
  name                    = var.group_name
  visibility              = "selected"
  selected_repository_ids = values(data.github_repository.this)[*].repo_id
}

Expected Behavior

When updating the list of selected repositories terraform updates list of these repos on the GitHub side.

Actual Behavior

The selected repositories list is set to empty after update.

Steps to Reproduce

  1. Create New Runners Group with some selected repos
  2. Run apply
  3. Update list of selected repos in terraform
  4. Run apply
@Vladyslav-Miletskyi
Copy link
Contributor Author

The problem might be caused by missing update functionality for selected_repos field

Vladyslav-Miletskyi added a commit to Vladyslav-Miletskyi/terraform-provider-github that referenced this issue Nov 8, 2021
jcudit pushed a commit that referenced this issue Nov 22, 2021
@jcudit
Copy link
Contributor

jcudit commented Dec 7, 2021

Any chance this was fixed by 3a19681?

@jcudit jcudit added Type: Bug Something isn't working as documented r/actions_runner_group labels Dec 7, 2021
@Vladyslav-Miletskyi
Copy link
Contributor Author

@jcudit yeah should be fixed

kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r/actions_runner_group Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

2 participants