[BUG] terraform plan is not empty when using github_branch_protection with actor names

[iAmoric]

Context

When using the github_branch_protection resource with actor names instead of actor IDs, the terraform plan after a terraform apply is not empty and wants to remove the actor IDs, even though it has not been used.

Example:

resource "github_branch_protection" "branch_protection" {
    required_pull_request_reviews {
        pull_request_bypassers = [
            "/iAmoric",
        ]
    }
}

First terraform apply:

$ terraform apply 
~ resource "github_branch_protection" "branch_protection" {
      ~ required_pull_request_reviews {
          ~ pull_request_bypassers          = [
              + "/iAmoric",        <== This is correct
            ]
        }
    }

Second terraform apply, done right after the first one:

$ terraform apply
~ resource "github_branch_protection" "branch_protection" {
      ~ required_pull_request_reviews {
          ~ pull_request_bypassers          = [
              - "MDQ6VXNlcjE0NTU1NjIx",        <== This is NOT correct
            ]
        }
    }

Expected behavior

Terraform plan should be empty when the first one was applied

Actual behavior

Terraform plan is not empty and wants to remove the actor ID

Steps to reproduce:

Run two times in a row terraform apply with the resource github_branch_protection using actor name

Additional context:

Full terraform code to easily reproduce the error:

  
  terraform {
    required_version = "1.3.1"
    required_providers {
      github = {
        source  = "integrations/github"
        version = "5.17.0"
      }
    }
  }

  provider "github" {
    token = "XXXXXX"
    owner = "XXXXXX"
  }

  data "github_team" "team" {
    slug = "my_team"
  }

  resource "github_repository" "repo" {
     name      = "test-branch-protection"
    auto_init = true
  }

  resource "github_branch_default" "default" {
    repository = github_repository.repo.name
    branch     = "main"

    depends_on = [github_repository.repo]
  }

  resource "github_team_repository" "team" {
    repository = github_repository.repo.name
    team_id    = data.github_team.team.id
    permission = "admin"
  }

  resource "github_branch_protection" "branch_protection" {
    repository_id = github_repository.repo.node_id
    pattern       = "main"

    enforce_admins = true

    required_pull_request_reviews {
      required_approving_review_count = 1
      pull_request_bypassers = [
        "/iAmoric",
      ]
    }

    push_restrictions = [
      data.github_team.team.node_id
    ]
  }

[Esysc]

Here is some debug logs.

[DEBUG] Problem setting 'require_last_push_approval' in <repo name> <branch> branch protection (< the ID>)
[WARN]  Provider "registry.terraform.io/integrations/github" produced an unexpected new value for module.github.github_branch_protection.settings["<repo name>:<branch>"] during refresh.
      - .required_pull_request_reviews[0].pull_request_bypassers: actual set element cty.StringVal("<User ID>") does not correlate with any element in plan
      - .required_pull_request_reviews[0].pull_request_bypassers: length changed from 1 to 2

that comes from

terraform-provider-github/github/resource_github_branch_protection.go

Line 314 in 9cf65a4

err = d.Set(PROTECTION_REQUIRES_LAST_PUSH_APPROVAL, protection.RequireLastPushApproval)