Bugfix: fix github_branch_protection required_status_checks not remov…

…ing contexts (#1492)

* fix github_branch_protection removing required_status_check contexts

Now when github_branch_protection.required_status_checks.contexts is changed from a non-empty list to an empty list, all status checks are removed from the branch protection.

* remove now unused githubV4STringSlice function

Co-authored-by: Keegan Campbell <me@kfcampbell.com>

github/resource_github_branch_protection.go

@@ -196,7 +196,7 @@ func resourceGithubBranchProtectionCreate(d *schema.ResourceData, meta interface
 		PushActorIDs:                   githubv4NewIDSlice(githubv4IDSlice(data.PushActorIDs)),
 		RepositoryID:                   githubv4.NewID(githubv4.ID(data.RepositoryID)),
 		RequiredApprovingReviewCount:   githubv4.NewInt(githubv4.Int(data.RequiredApprovingReviewCount)),
-		RequiredStatusCheckContexts:    githubv4NewStringSlice(githubv4StringSlice(data.RequiredStatusCheckContexts)),
+		RequiredStatusCheckContexts:    githubv4NewStringSlice(githubv4StringSliceEmpty(data.RequiredStatusCheckContexts)),
 		RequiresApprovingReviews:       githubv4.NewBoolean(githubv4.Boolean(data.RequiresApprovingReviews)),
 		RequiresCodeOwnerReviews:       githubv4.NewBoolean(githubv4.Boolean(data.RequiresCodeOwnerReviews)),
 		RequiresCommitSignatures:       githubv4.NewBoolean(githubv4.Boolean(data.RequiresCommitSignatures)),
@@ -368,7 +368,7 @@ func resourceGithubBranchProtectionUpdate(d *schema.ResourceData, meta interface
 		Pattern:                        githubv4.NewString(githubv4.String(data.Pattern)),
 		PushActorIDs:                   githubv4NewIDSlice(githubv4IDSlice(data.PushActorIDs)),
 		RequiredApprovingReviewCount:   githubv4.NewInt(githubv4.Int(data.RequiredApprovingReviewCount)),
-		RequiredStatusCheckContexts:    githubv4NewStringSlice(githubv4StringSlice(data.RequiredStatusCheckContexts)),
+		RequiredStatusCheckContexts:    githubv4NewStringSlice(githubv4StringSliceEmpty(data.RequiredStatusCheckContexts)),
 		RequiresApprovingReviews:       githubv4.NewBoolean(githubv4.Boolean(data.RequiresApprovingReviews)),
 		RequiresCodeOwnerReviews:       githubv4.NewBoolean(githubv4.Boolean(data.RequiresCodeOwnerReviews)),
 		RequiresCommitSignatures:       githubv4.NewBoolean(githubv4.Boolean(data.RequiresCommitSignatures)),

github/util_v4.go

@@ -21,8 +21,8 @@ func expandNestedSet(m map[string]interface{}, target string) []string {
 	return res
 }
 
-func githubv4StringSlice(ss []string) []githubv4.String {
-	var vGh4 []githubv4.String
+func githubv4StringSliceEmpty(ss []string) []githubv4.String {
+	vGh4 := make([]githubv4.String, 0)
 	for _, s := range ss {
 		vGh4 = append(vGh4, githubv4.String(s))
 	}