Support for Rails 5.1 #94
Conversation
|
@rmm5t Do we need to test against multiple |
krasnoukhov
force-pushed
the
rails5.1
branch
from
7542296 to
b4457b3
Compare
Yes! Absolutely. What isn't reasonable about that? |
|
Changes Unknown when pulling 7542296 on simplepractice:rails5.1 into ** on integrallis:master**. |
|
@rmm5t I'm just not sure how this is helpful for this gem. I can understand testing against multiple Ruby versions, but rvm? What does that help to achieve? |
|
@rmm5t Oh please nevermind, it's is actually Ruby versions, I just forgot that travis config is a little bit confusing |
krasnoukhov
force-pushed
the
rails5.1
branch
from
b4457b3 to
9e1840b
Compare
.travis.yml
Outdated
| rvm: | ||
| - 2.2.7 | ||
| - 2.3.4 | ||
|
|
There was a problem hiding this comment.
Please don't rip out permutations from the build matrix. These are all here for a reason. If you think a version or permutation should be dropped, that should be reserved for an entirely separate Issue discussion and PR. It's not appropriate to co-opt a PR with something like this.
There was a problem hiding this comment.
I'm sorry about that, I just confused this with actual RVM versions 😆 #94 (comment)
Appraisals
Outdated
| appraise "rails3.2" do | ||
| gem "rails", "~> 3.2.0" | ||
| end | ||
|
|
There was a problem hiding this comment.
Related. This needs to be put back.
There was a problem hiding this comment.
Ok, let me see if I can get it to work. Just FYI, Rails 3.2 isn't really supported by a core team anymore: http://guides.rubyonrails.org/maintenance_policy.html#severe-security-issues
Ah, yes, I don't like that Travis designates different ruby versions with with the |
|
Changes Unknown when pulling 9e1840b on simplepractice:rails5.1 into ** on integrallis:master**. |
1 similar comment
|
Changes Unknown when pulling 9e1840b on simplepractice:rails5.1 into ** on integrallis:master**. |
krasnoukhov
force-pushed
the
rails5.1
branch
from
9e1840b to
4bed8b0
Compare
|
@rmm5t All should be fixed now. Rails 3.2 support is also there |
|
Changes Unknown when pulling 4bed8b0 on simplepractice:rails5.1 into ** on integrallis:master**. |
|
And the build is green. @rmm5t Please let me know if there's anything else outstanding |
|
Good work. Thanks! 🍻 |
deep_symbolize_keys#85