Fix deprecation warning on Ruby 2.7 and test against on Travis #130
Conversation
Travis allows you to include Ruby versions that are not in the matrix. The goal is to make it so newer versions are defined and any older versions are exceptions. As of this change Ruby 2.3 and 2.4 are officially end of life.
Adds Ruby 2.7 so tests are run against it. It appears Rails 5.1+ will run on Ruby 2.7. I've also switched rails-master to use whatever the current stable version of ruby is which should avoid having to update the line again in the future.
Using `Proc.new` to capture the block is deprecated. I believe this supports the intended behavior or accepting either an object that responds to #call or a block.
Constraint was added in 4986fce due to some dependencies of dependencies. I'm betting those have been fixed in the last 3 years.
There was a problem hiding this comment.
Thanks for the work here! I'm not going to hold this up, but for future reference, this is conflating two areas of concern and should have been two separate PRs.
https://medium.com/@fagnerbrack/one-pull-request-one-concern-e84a27dfe9f1
- Fix the deprecation warning in 2.7 while adding 2.7 to build matrix.
Remove deprecated ruby versions from build matrix (and reorganize)Refactor build matrix
Just want to clarify that it's really just reorganizing how those older versions are run. The set of builds for old versions of Ruby and Rails before and after this change are the same, so none of the end-of-life versions of Ruby have been removed from the build matrix. |
|
@rmm5t If the changes look good, any chance we could get this merged? |
|
Sorry for the delay. Thanks for the excellent work here! |
|
Thanks @gaffneyc you're a legend ❤️ |
This adds Ruby 2.7 to the test matrix, reorganizes it to make 2.3 and 2.4 (both end-of-life) to be included exceptions, and fixes a deprecation warning on Ruby 2.7. I also ran into a different deprecation warning running under and old version of Rake so I've tried to relax the constraint.
Closes #129