Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports for python 3 #56

Merged
merged 3 commits into from
Oct 2, 2017
Merged

Conversation

djsutherland
Copy link
Contributor

#54 apparently wasn't tested on python 3; it tries to do some relative import stuff, which doesn't work. This fixes it.

I also noticed that setup.py uses install_requires but doesn't actually use setuptools.setup, so that line only does anything if you're installing with pip and not if you're using setup.py directly. I changed it to use setuptools if available.

@martindurant
Copy link
Member

martindurant commented Sep 24, 2017

Does this now need a from __future__ import for imports to work on py2?

@djsutherland
Copy link
Contributor Author

djsutherland commented Sep 24, 2017

Not in 2.7 (I tested). I think this syntax was introduced in 2.5, IIRC.

Edit: tested 2.6 and it works, too.

@martindurant
Copy link
Member

All looks ok to me - anyone else with comments?

@martindurant martindurant merged commit 82bf339 into intake:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants