python2 compatibilty fix by Mika Eloranta #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we support py2? I don't see any wheels, and conda-forge no longer builds for py2. None of the tests above run on py2. |
|
Well, it seems that is what the ubuntu 20.x is running in the failing test case ? I just wanted to see if this would fix it but it did not. |
|
Either python2 support should be fixed, or the CI/CD should remove the python2 cases (eg on the ubuntu 20.04 test case) |
|
OK, running this now - and we can consider dropping py2 in a separate issue/PR. Sorry for the wait! |
|
Does not seem to resolve failures |
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.