Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace references to collection with catalog #457

Merged
merged 12 commits into from
Mar 24, 2022
Merged

Conversation

jukent
Copy link
Collaborator

@jukent jukent commented Mar 11, 2022

Change Summary

Updating documentation to be more consistent in references to catalog vs collection.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@jukent jukent added the documentation Documentation related label Mar 11, 2022
@jukent jukent marked this pull request as ready for review March 24, 2022 20:17
@jukent jukent requested a review from andersy005 as a code owner March 24, 2022 20:17
README.md Outdated Show resolved Hide resolved
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jukent 🚀

@jukent jukent merged commit 84f945b into intake:main Mar 24, 2022
@jukent jukent deleted the documentation branch March 24, 2022 20:40
@jukent
Copy link
Collaborator Author

jukent commented Mar 24, 2022

@andersy005 Should I do a similar effort to be very intentional about the term "collection" in the intake repository?

@andersy005
Copy link
Member

Can you point me to these "collections" references in the intake repository?

@jukent
Copy link
Collaborator Author

jukent commented Mar 25, 2022

In a few .rst files it is used mostly in the definition of things
https://github.com/intake/intake/search?q=collection

For example in deployment.rst mentions intake-esm and uses the following syntax:
col = intake.open_esm_metadatastore(collection_input_definition="GLADE-CMIP5")

@andersy005
Copy link
Member

good catch! that page is definitely out-of-date and an update would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Documentation to use new tutorial.py module for grabbing catalog URLs
2 participants