Tests and some BFs for HP devices #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full cov test suites for: - HP3456a - HP6624a - HP6632b - HP6652a - HPe3631a Bug fix: - HPe3631a: Raise an error that was previously returned Changes: - HP3456a: Remove `if self._testing` statement to not do `time.sleep` during tests. Instead use an automatically used pytest fixture to mock out `time.sleep`.
trappitsch
commented
Nov 5, 2020
trappitsch
commented
Nov 5, 2020
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full cov test suites for:
Bug fix:
Changes:
if self._testingstatement to not dotime.sleepduring tests. Instead use an automatically used pytest fixture to
mock out
time.sleep.