Tests for Yokogawa 7651 and tests + BF for Yokogawa 6370 #251
Conversation
- Full test suite for Yokogawa 7651
- Extended test suite for Yokogawa 6370 for complete coverage
- Found two small bugs in Yokogawa 6370:
- Routines `data` and `wavelength`, both return the data for the
active trace, returned the method itself instead of the data.
- These were also the two untested routines.
|
|
||
| def wavelength(self): | ||
| """ | ||
| Query the wavelength axis of the active trace. | ||
| """ | ||
| return self.channel[self.active_trace].wavelength | ||
| return self.channel[self.active_trace].wavelength() |
There was a problem hiding this comment.
I think there is a TODO brewing here. I'd say out of scope for this PR, but we should think about if we want to make wavelength a property
There was a problem hiding this comment.
These two methods for data and wavelength are simply a shortcut to access the currently active channel. The channels themselves in fact also have the additional arguments for bin_format:
def data(self, bin_format=True):For oscilloscopes for example, getting data is also always defined as methods to allow for a bin_format argument. If we want to turn it into a method there is the question on how to implement the bin_format, maybe with a separate property on the data transfer format? If it is left as a method, it would be good to pass the bin_format through in these methods. What do you think? That latter could easily be included here.
There was a problem hiding this comment.
I think this is something we will have to think about by taking a look at the manual and seeing how we might expect the user to use the wavelength data here. I'm not super familiar with the instrument so I would need to check that first.
This is def a later-thing though, and I'm okay with how it is right now!
| # METHODS # | ||
|
|
||
|
|
||
| @given(values=st.lists(st.decimals(allow_infinity=False, allow_nan=False), |
There was a problem hiding this comment.
Great use of hypothesis 👍
There was a problem hiding this comment.
Totally stolen from further up in the test suite. But that's one way to start. More to come 😃
Tests
Bug fixes
dataandwavelength, both return the data for theactive trace, returned the method itself instead of the data.