Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: implement new API to also handle multiple transcoding outputs #8

Merged
merged 8 commits into from
Nov 29, 2024
Merged

feat!: implement new API to also handle multiple transcoding outputs #8

merged 8 commits into from
Nov 29, 2024

Conversation

bajankristof
Copy link
Collaborator

@bajankristof bajankristof commented Nov 28, 2024 •
edited
Loading

  • Added new, more powerful (though less extensible) DSL to build ffmpeg commands.
  • Introduced new concept of long-lived presets and transcoders.
  • Removed full output storage during the transcoding process.
  • Added built-in presets that can be used out-of-the-box:
    • H.264 360p all the way up to 4K resolution.
    • AAC 128k all the way up to 320k bit rate.
    • DASH H.264 360p all the way up to 4K resolution.
    • DASH AAC 128k all the way up to 320k bit rate.
  • Dropped support for Ruby 3.0, Ruby 3.1 is now the minimum supported version.

Refs: ARC-9901

@kiskoza kiskoza self-requested a review November 28, 2024 08:33
@bajankristof
feat!: implement new and better API to also handle multiple transcodi…
c63da81 
…ng outputs

- Added new, more powerful (though less extensible) DSL to build ffmpeg commands.
- Introduced new concept of long-lived presets and transcoders.
- Removed full output storage during the transcoding process.
- Added built-in presets that can be used out-of-the-box:
  - H.264 360p all the way up to 4K resolution.
  - AAC 128k all the way up to 320k bit rate.
  - DASH H.264 360p all the way up to 4K resolution.
  - DASH AAC 128k all the way up to 320k bit rate.
- Dropped support for Ruby 3.0, Ruby 3.1 is now the minimum supported version.

Refs: ARC-9901
@bajankristof
test: reduce flakyness in transcoder spec
74744a8 
Refs: ARC-9901
@bajankristof
feat(presets): add preset to create simple thumbnails
92471a6 
Refs: ARC-9901
@bajankristof
fix(logging): update logs to include the correct procname
1389cdb 
Refs: ARC-9901
kiskoza
kiskoza requested changes Nov 28, 2024
View reviewed changes
.ruby-version Show resolved Hide resolved
lib/ffmpeg.rb Outdated Show resolved Hide resolved
lib/ffmpeg/command_args.rb Outdated Show resolved Hide resolved
lib/ffmpeg/filters/scale.rb Show resolved Hide resolved
lib/ffmpeg/filters/scale.rb Outdated Show resolved Hide resolved
lib/ffmpeg/raw_command_args.rb Show resolved Hide resolved
lib/ffmpeg/reporters/progress.rb Outdated Show resolved Hide resolved
lib/ffmpeg/reporters/silence.rb Outdated Show resolved Hide resolved
ZoltanDalmadi
ZoltanDalmadi approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@ZoltanDalmadi ZoltanDalmadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new features are really nicely put together, kudos

@bajankristof bajankristof merged commit cd80633 into main Nov 29, 2024
13 checks passed
@bajankristof bajankristof deleted the feat/multi-output branch December 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoltanDalmadi ZoltanDalmadi ZoltanDalmadi approved these changes

@kiskoza kiskoza kiskoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bajankristof @kiskoza @ZoltanDalmadi